Skip to content

[CI] Add pre-commit hook check-json#1311

Merged
jiayuasu merged 1 commit intoapache:masterfrom
jbampton:add-pre-commit-hook-check-json
Jun 6, 2025
Merged

[CI] Add pre-commit hook check-json#1311
jiayuasu merged 1 commit intoapache:masterfrom
jbampton:add-pre-commit-hook-check-json

Conversation

@jbampton
Copy link
Member

@jbampton jbampton commented Apr 3, 2024

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

  • No this is a CI update. The PR name follows the format [CI] my subject

What changes were proposed in this PR?

Added another hook to our pre-commit framework:

https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#check-json

How was this patch tested?

With the new hook check-json added I first ran locally:

pre-commit run --all-files

which showed the JSON files that weren't valid JSON.

Then checked some JSON with JSON Lint online.

https://jsonlint.com/

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

@jbampton jbampton marked this pull request as draft April 3, 2024 10:46
@jbampton jbampton self-assigned this Oct 29, 2024
@jbampton jbampton force-pushed the add-pre-commit-hook-check-json branch from 7338925 to 0347ff4 Compare June 6, 2025 00:19
@jbampton jbampton changed the title [SEDONA-527] Add pre-commit hook check-json; Lint JSON files [CI] Add pre-commit hook check-json Jun 6, 2025
@jbampton jbampton marked this pull request as ready for review June 6, 2025 00:28
@jbampton jbampton requested a review from jiayuasu as a code owner June 6, 2025 00:28
@jiayuasu jiayuasu merged commit f6361b8 into apache:master Jun 6, 2025
3 checks passed
@jbampton jbampton deleted the add-pre-commit-hook-check-json branch June 6, 2025 20:39
Kontinuation pushed a commit to Kontinuation/sedona that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants